fixes ImageNet, SimpleRNN examples #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- QOL improvements for AMDGPU
DhruvDh
commented
Feb 24, 2024
avik-pal
requested changes
Feb 24, 2024
avik-pal
reviewed
Feb 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 87.40% 87.53% +0.12%
==========================================
Files 30 30
Lines 1643 1644 +1
==========================================
+ Hits 1436 1439 +3
+ Misses 207 205 -2 ☔ View full report in Codecov by Sentry. |
- use 32-bit float in SimpleRNN for Metal compatibility
DhruvDh
commented
Feb 25, 2024
avik-pal
reviewed
Feb 25, 2024
|
Our GPU CIs are down atm and I don't think are going to be online before the next week, so we will have to wait till then to merge |
This reverts commit 9740ade.
avik-pal
reviewed
Feb 25, 2024
avik-pal
reviewed
Feb 25, 2024
|
Thanks for the fixes, merged it via the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
Running the
resnetmodel per the example from the ImageNet README requires addingFluxandMetalheadper theBlotzREADME. I added those and replicated theunsafe_free!for AMDGPU.I am new to Julia so sorry if something isn't quite right.
Also added the fix to #498 mentioned in the conversation.